Re: [code] [textadept][PATCH] Fix for ncurses targets

From: Mitchell <m.att.foicica.com>
Date: Thu, 8 Nov 2012 08:44:48 -0500 (Eastern Standard Time)

Hi,

On Tue, 6 Nov 2012, lists.att.drwilly.de wrote:

> On Nov 06, 2012 09:14, Mitchell wrote:
>> Hi,
>>
>> On Mon, 5 Nov 2012, lists.att.drwilly.de wrote:
>>
>>> Fixes a compiler error when running 'make textadept-ncurses' form
>>> command line
>>>
>>
>> Thanks, but the rule is 'ncurses' and in the manual the command is stated
>> as 'make ncurses'. If your patch is applied, any goal that contains
>> 'ncurses' would build textadept-ncurses (e.g. 'make foo-ncurses') and that
>> doesn't seem appropriate. Do other projects use this convention? I am
>> unaware of it.
>
> Any goal that contains "ncurses" would set the -DNCURSES and -lncursesw flags rather than just the goal ncurses.
> I don't think that is the best solution either but since building both of the *jit targets failed I wanted to build the textadept targets indepedent of the jit targets.

I am curious why the jit targets did not build for you. What were the
error messages? Perhaps I overlooked something.

> A different issue, but since you mentioned conventions:
> Makefile line 70 you set the DESTDIR variable, which you shouldn't.
> https://www.gnu.org/prep/standards/html_node/DESTDIR.html

Okay, thanks for pointing this out.

Mitchell

-- 
You are subscribed to code.att.foicica.com.
To change subscription settings, send an e-mail to code+help.att.foicica.com.
To unsubscribe, send an e-mail to code+unsubscribe.att.foicica.com.
Received on Thu 08 Nov 2012 - 08:44:48 EST

This archive was generated by hypermail 2.2.0 : Fri 09 Nov 2012 - 06:41:26 EST