Re: [code] [scinterm][PATCHES] fix compilation on 64-bit

From: Mitchell <m.att.foicica.com>
Date: Mon, 18 Mar 2013 10:47:37 -0400 (Eastern Daylight Time)

Hi Robin,

On Sun, 17 Mar 2013, Robin Haberkorn wrote:

> Hi guys!
>
> Here's a Scinterm patch fixing compilation on certain 64-bit setups:
> https://github.com/rhaberkorn/sciteco/blob/master/patches/scinterm-fix-64-bit.patch
>
> I did not experience this compilation error ("loss of precision") on my
> older (now broken) 64-bit Ubuntu, even though sizeof(attr_t) was
> probably smaller than sizeof(void *) on it as well.
> So complaining about the cast could be relatively new GCC behaviour.
> I'm using gcc 4.6 and I know a "loss of precision" error also occurs
> with gcc 4.7 on x64-bit Linux and OS-X (llvm-gcc).
>
> A small Makefile patch that introduces an AR variable is also attached.
> I use this when cross-compiling for Mingw32 on Linux to explicitly set
> the archiver to use on the make command line.

Thanks :) I will apply these patches.

> Another patch in the SciTECO repository could also be of interest for
> you:
> https://github.com/rhaberkorn/sciteco/blob/master/patches/scintilla-teco-control-codes.patch

I am reluctant to apply this just because I don't know enough about the
internals of Scintilla on whether DrawTextNoClip() can be called elsewhere
where rc.left > rc.right; I'm not sure how to test this.

Cheers,
Mitchell

-- 
You are subscribed to code.att.foicica.com.
To change subscription settings, send an e-mail to code+help.att.foicica.com.
To unsubscribe, send an e-mail to code+unsubscribe.att.foicica.com.
Received on Mon 18 Mar 2013 - 10:47:37 EDT

This archive was generated by hypermail 2.2.0 : Tue 19 Mar 2013 - 06:47:55 EDT