Re: [code] Bug in bookmarks.lua

From: Robert Gieseke <rob.g.att.web.de>
Date: Wed, 13 Jan 2016 18:28:15 +0100

Hi Brian,

thanks a lot, I've committed your pull request so this is fixed now in
Textredux!

Cheers,
Robert

Am 13/01/16 um 02:09 schrieb Brian Schott:
> I didn't notice that, nor did I read past the part of the API docs that
> says it can return a number or a string. (I don't usually write code in
> languages that let you do that).
>
> I filed an issue here:
> https://github.com/rgieseke/textredux/issues/22
>
> On Tue, Jan 12, 2016 at 5:03 PM, Mitchell <m.att.foicica.com> wrote:
>
>> Hi Brian,
>>
>>
>> On Tue, 12 Jan 2016, Brian Schott wrote:
>>
>>
>>> http://foicica.com/hg/textadept/file/917cfa3541e5/modules/textadept/bookmarks.lua#l72
>>>
>>> This needs to read:
>>>
>>> if button ~= 1 or not mark then return end
>>>
>>> because filtered lists return numbers, not strings. Right now it's
>>> impossible to actually go to bookmarks that have been set.
>>>
>>
>> Hmm. Line 70, "string_output = true" instructs a string return, which
>> would be the button's label. Therefore I'm able to jump to the selected
>> bookmark.
>>
>> Cheers,
>> Mitchell
>> --
>> You are subscribed to code.att.foicica.com.
>> To change subscription settings, send an e-mail to code+help.att.foicica.com.
>> To unsubscribe, send an e-mail to code+unsubscribe.att.foicica.com.
>>
>>
>

-- 
You are subscribed to code.att.foicica.com.
To change subscription settings, send an e-mail to code+help.att.foicica.com.
To unsubscribe, send an e-mail to code+unsubscribe.att.foicica.com.
Received on Wed 13 Jan 2016 - 12:28:15 EST

This archive was generated by hypermail 2.2.0 : Thu 14 Jan 2016 - 06:54:48 EST