Re: [code] PATCH: Silence some compilation warnings; lspawn.c

From: Markus F.X.J. Oberhumer <markus.att.oberhumer.com>
Date: Wed, 24 Aug 2016 16:03:21 +0200

Hi Mitchell,

here is an interesting warning spotted by clang-3.9 - this probably indicates
a bug: the "||" should be a "&&":

gtdialog.c:595:39: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
        if (type >= GTDIALOG_INPUTBOX ||
            ~~~~~~~~~~~~~~~~~~~~~~~~~~^~

Cheers,
markus

On 2016-08-23 23:50, Mitchell wrote:
> Hi Markus,
>
> On Thu, 18 Aug 2016, Markus F.X.J. Oberhumer wrote:
>
>> It's always worthwhile to compile on high warning levels like "-Wall -Wextra
>> -Werror",
>> but it needs some efforts to clean up existing code - but then these are
>> usually
>> just trivial patches.
>>
>> [snip]
>
> I've applied your changes to lspawn.c and also made some changes to gtdialog.c
> (the latter had quite a few warnings I wasn't aware of). I'm using the "-W
> -Wall -Wno-unused" compile flags now. Thanks for the prodding.
>
> Cheers,
> Mitchell

-- 
Markus Oberhumer, <markus@oberhumer.com>, http://www.oberhumer.com/
-- 
You are subscribed to code.att.foicica.com.
To change subscription settings, send an e-mail to code+help.att.foicica.com.
To unsubscribe, send an e-mail to code+unsubscribe.att.foicica.com.
Received on Wed 24 Aug 2016 - 10:03:21 EDT

This archive was generated by hypermail 2.2.0 : Thu 25 Aug 2016 - 06:39:26 EDT