Re: [code][Textadept] hardcoded title font size in Markdown lexer

From: Mitchell <m.att.foicica.com>
Date: Thu, 17 Aug 2017 21:17:13 -0400 (EDT)

Hi,

On Thu, 17 Aug 2017, Robert Gieseke wrote:

> Am 17/08/17 um 08:46 schrieb Franck Guadagnini:
>>>>
>>>> local font_size = 10
>>>>
>>>> by
>>>>
>>>> local font_size = buffer.property['fontsize'].
>>>>
>>>> Mitchell, you may be interested in pushing this little change
>>>> upstream?
>>>
>>> This would work for Textadept, but the lexers are part of another
>>> project, Scintillua[1], that is editor-agnostic. Applying this
>>> change would break lexing for downstream users. I completely agree
>>> that hardcoding the size is not ideal, but I'm not sure what the
>>> best solution is. Forcing downstream users to define a
>>> markdown-specific property is not something I'd want to do. If you
>>> have another suggestion, I'd be happy to hear. Otherwise, keeping
>>> your own copy of *markdown.lua* with your change is probably best
>>> for now.
>
> Maybe this could be done in a conditional, if buffer.property exists use
> it, else set it to 10?

Thanks for the idea. I've just committed a fix[1] that makes use of buffer properties.

Cheers,
Mitchell

[1]: http://foicica.com/hg/scintillua/rev/6533bec9bf9e

-- 
You are subscribed to code.att.foicica.com.
To change subscription settings, send an e-mail to code+help.att.foicica.com.
To unsubscribe, send an e-mail to code+unsubscribe.att.foicica.com.
Received on Thu 17 Aug 2017 - 21:17:13 EDT

This archive was generated by hypermail 2.2.0 : Fri 18 Aug 2017 - 06:39:28 EDT